linux-kernel - Re: [PATCH v3 0/2] media: qcom: camss: Re-structure camss_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b27fe267-c722-4133-ad7c-bdb1ff573ee7@linaro.org>
Date: Mon, 25 Nov 2024 13:57:09 +0200
From: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel@...cinc.com
Subject: Re: [PATCH v3 0/2] media: qcom: camss: Re-structure
 camss_link_entities

Hi Vikram,

On 11/25/24 12:34, Vikram Sharma wrote:
> Refactor the camss_link_entities function by breaking it down into
> three distinct functions. Each function will handle the linking of
> a specific entity separately, enhancing readability.
> 
> Changes in V3:
> - Broke down the change in 2 patches. first one to functionally
> decompose link error message. second to restrcture the link
> function.
> - Removed the declarion of camss_link_error from header file.
> - Link to v2: https://lore.kernel.org/linux-arm-msm/20241112133846.2397017-1-quic_vikramsa@quicinc.com/

as I said last time I don't see the value of these changes.

Since the changes are non-functional, then hopefully there should be
no issues with them, however I really miss the point of adding 65
lines of code for a questionable reason and at the price of increased
complexity.

Is there a good reason not to drop the series?

> Changes in V2:
> - Declared variables in reverse christmas tree order.
> - Functionally decomposed link error message.
> - Link to v1: https://lore.kernel.org/linux-arm-msm/20241111173845.1773553-1-quic_vikramsa@quicinc.com/
> 
>    To: Robert Foss <rfoss@...nel.org>
>    To: Todor Tomov <todor.too@...il.com>
>    To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>    Cc: linux-media@...r.kernel.org
>    Cc: linux-kernel@...r.kernel.org
> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
> 
> Vikram Sharma (2):
>    media: qcom: camss: reducing the repitious error message string
>    media: qcom: camss: Restructure camss_link_entities
> 
>   drivers/media/platform/qcom/camss/camss.c | 195 ++++++++++++++--------
>   1 file changed, 130 insertions(+), 65 deletions(-)
> 

--
Best wishes,
Vladimir