linux-kernel - Re: [PATCH net v1 1/2] net: usb: lan78xx: Fix double free issue with interrupt buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173249523051.3406669.14794155201362335327.git-patchwork-notify@kernel.org>
Date: Mon, 25 Nov 2024 00:40:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, woojung.huh@...rochip.com, andrew+netdev@...n.ch,
 john.efstathiades@...blebay.com, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 UNGLinuxDriver@...rochip.com, phil@...pberrypi.org
Subject: Re: [PATCH net v1 1/2] net: usb: lan78xx: Fix double free issue with
 interrupt buffer allocation

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 16 Nov 2024 14:05:57 +0100 you wrote:
> In lan78xx_probe(), the buffer `buf` was being freed twice: once
> implicitly through `usb_free_urb(dev->urb_intr)` with the
> `URB_FREE_BUFFER` flag and again explicitly by `kfree(buf)`. This caused
> a double free issue.
> 
> To resolve this, reordered `kmalloc()` and `usb_alloc_urb()` calls to
> simplify the initialization sequence and removed the redundant
> `kfree(buf)`.  Now, `buf` is allocated after `usb_alloc_urb()`, ensuring
> it is correctly managed by  `usb_fill_int_urb()` and freed by
> `usb_free_urb()` as intended.
> 
> [...]

Here is the summary with links:
  - [net,v1,1/2] net: usb: lan78xx: Fix double free issue with interrupt buffer allocation
    https://git.kernel.org/netdev/net/c/03819abbeb11
  - [net,v1,2/2] net: usb: lan78xx: Fix memory leak on device unplug by freeing PHY device
    https://git.kernel.org/netdev/net/c/ae7370e61c5d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html