linux-kernel - Re: [PATCH v2] mtd: spi-nor: macronix: remove mx25u25635f from parts list to enable SFDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mafs0iksb5s8r.fsf@kernel.org>
Date: Mon, 25 Nov 2024 13:59:32 +0000
From: Pratyush Yadav <pratyush@...nel.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Parth Pancholi <parth105105@...il.com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <mwalle@...nel.org>,  Miquel Raynal
 <miquel.raynal@...tlin.com>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  Parth Pancholi
 <parth.pancholi@...adex.com>,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mtd: spi-nor: macronix: remove mx25u25635f from
 parts list to enable SFDP

On Mon, Nov 11 2024, Tudor Ambarus wrote:

> On 11/5/24 10:58 AM, Parth Pancholi wrote:
>> From: Parth Pancholi <parth.pancholi@...adex.com>
>> 
>> The Macronix mx25u25635f flash device supports SFDP initialization.
>> This commit removes the specific mx25u25635f entry (NOR ID 0xc22539),
>> along with its size and flags, from the NOR parts list. By removing
>> this entry, both mx25u25635f and mx25u25645g (which share the same
>> NOR ID) will utilize the generic flash driver configuration.
>> 
>> This change allows both devices (mx25u25635f and mx25u25645g) to
>> leverage SFDP-defined parameters, enabling dual and quad read
>> operations without the need for manual adjustment of no_sfdp_flags.
>
> I'm fine with this. We may re-add an entry when BP is used or if someone
> reports there's a flash with this ID that doesn't support SFDP, which
> has a reasonable amount of probability for macronix flashes, but I'm ok
> taking the risk and fixing it afterwards if reported.

Sounds good. Would be a good idea to queue it early after -rc1 so it
gets some time to bake in linux-next.

Reviewed-by: Pratyush Yadav <pratyush@...nel.org>

-- 
Regards,
Pratyush Yadav