| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241125-work-cred-v2-24-68b9d38bb5b2@kernel.org> Date: Mon, 25 Nov 2024 15:10:20 +0100 From: Christian Brauner <brauner@...nel.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Amir Goldstein <amir73il@...il.com>, Miklos Szeredi <miklos@...redi.hu>, Al Viro <viro@...iv.linux.org.uk>, Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, Christian Brauner <brauner@...nel.org> Subject: [PATCH v2 24/29] cgroup: avoid pointless cred reference count bump of->file->f_cred already holds a reference count that is stable during the operation. Signed-off-by: Christian Brauner <brauner@...nel.org> --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1a94e8b154beeed45d69056917f3dd9fc6d950fa..d9061bd55436b502e065b477a903ed682d722c2e 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5216,11 +5216,11 @@ static ssize_t __cgroup_procs_write(struct kernfs_open_file *of, char *buf, * permissions using the credentials from file open to protect against * inherited fd attacks. */ - saved_cred = override_creds(get_new_cred(of->file->f_cred)); + saved_cred = override_creds(of->file->f_cred); ret = cgroup_attach_permissions(src_cgrp, dst_cgrp, of->file->f_path.dentry->d_sb, threadgroup, ctx->ns); - put_cred(revert_creds(saved_cred)); + revert_creds(saved_cred); if (ret) goto out_finish; -- 2.45.2
Powered by blists - more mailing lists