linux-kernel - Re: [PATCH v6 00/18] Implement DWARF modversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72m4fea15Z0fFZauz8N2madkBJ0G7Dc094OwoajnXmROOA@mail.gmail.com>
Date: Mon, 25 Nov 2024 15:41:24 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Neal Gompa <neal@...pa.dev>
Cc: Sami Tolvanen <samitolvanen@...gle.com>, Masahiro Yamada <masahiroy@...nel.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Matthew Maurer <mmaurer@...gle.com>, 
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>, 
	Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...sung.com>, 
	Hector Martin <marcan@...can.st>, Janne Grunau <j@...nau.net>, Miroslav Benes <mbenes@...e.cz>, 
	Asahi Linux <asahi@...ts.linux.dev>, Sedat Dilek <sedat.dilek@...il.com>, 
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-modules@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	"Darrick J. Wong" <djwong@...nel.org>, Donald Zickus <dzickus@...hat.com>
Subject: Re: [PATCH v6 00/18] Implement DWARF modversions

On Mon, Nov 25, 2024 at 2:29 PM Neal Gompa <neal@...pa.dev> wrote:
>
> As my Acked-by was removed, I'm sorry to say that there is no point
> for me to provide feedback since it is unwanted.
>
> I hope it lands soon, but I also hope the people here who decided that
> a person's efforts aren't worth recording because they don't
> personally know them should reflect on this too. It's a good way to
> keep people from coming into the community for the long term.

Hopefully this reply helps -- apologies to anyone if I am overstepping.

On one side, it is true that Acked-by is typically used by people that
is responsible for the code one way or another, because the tag is
meant for them to acknowledge they are OK with the change going in,
and so I can see the argument that restricting it for that purpose
only may help avoid confusion later on reading the log.

On the other hand, someone being willing to put their name on a patch
is very valuable, whoever they are, and whatever the tag name is.
Moreover, it is also true that, Acked-by may be used here in a "as a
key user downstream, this looks reasonable and satisfies our needs"
sense.

Finally, sometimes new tags are invented on the fly because there is
no good fit, too.

Either way, I don't think anyone wanted to disregard your efforts or
to be rude to you in particular, but rather wanted to keep tags usage
aligned to how they view them or how they use them in their subsystem.
The Tested-by was still wanted, so I doubt their goal was to remove
you from the log or to make you feel unwelcomed.

Two solutions here that could be OK for both sides:

  - Would you be OK with another tag name? For instance,
"Acked-by-User:" or similar? That may help the maintainer keep the
Acked-bys the way they prefer, yet record your own Acked-by in a
separate category.

  - Another idea that the maintainer may accept is an Acked-by with a
"# suffix" comment that clarifies the meaning in this particular case,
e.g.:

      Acked-by: Neal Gompa <neal@...pa.dev> # As primary consumer
(Fedora Asahi kernel maintainer).

Cheers,
Miguel