linux-kernel - Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dc16c95-6849-41c8-86da-d1c0c74cb3e4@kernel.org>
Date: Mon, 25 Nov 2024 15:53:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hector Martin <marcan@...can.st>,
 Sasha Finkelstein <fnkl.kernel@...il.com>
Cc: Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig
 <alyssa@...enzweig.io>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display
 controller bindings

On 25/11/2024 15:14, Hector Martin wrote:
>>> +
>>> +  "#address-cells":
>>> +    const: 1
>>> +
>>> +  "#size-cells":
>>> +    const: 0
>>> +
>>> +additionalProperties: true
>>
>> This cannot be true. Must be false.
>>
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - interrupts
>>
>> This goes before additionalProperties.
>>
>> Missing example: that's a strong NAK and prove that this could not be
>> even tested.
>>
>> Do you see any device schema without example? No. Do not develop things
>> differently, Apple is not unique, special or exceptional.
> 
> Krzysztof, it is entirely possible to express this same feedback without
> being condescending and rude. I'm pretty sure you can do better than this.

Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.

Instead of patronizing, note that this was just pure observation - this
was done entirely than other bindings, which should be taken as an
example. Or example-schema should be taken as example... Pointing out
issues and inconsistencies is not rude or condescending. Basically now
you are condescending people's feedback which further restricts review
process allowing comments which you approve.

You got here one day review, enjoy that.

Best regards,
Krzysztof