linux-kernel - Re: [PATCH] fs/ceph/mds_client: give up on paths longer than PATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKPOu+8u1Piy9KVvo+ioL93i2MskOvSTn5qqMV14V6SGRuMpOw@mail.gmail.com>
Date: Mon, 25 Nov 2024 14:59:39 +0100
From: Max Kellermann <max.kellermann@...os.com>
To: Alex Markuze <amarkuze@...hat.com>
Cc: Patrick Donnelly <pdonnell@...hat.com>, Jeff Layton <jlayton@...nel.org>, 
	Ilya Dryomov <idryomov@...il.com>, Venky Shankar <vshankar@...hat.com>, xiubli@...hat.com, 
	ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org, dario@...e53.de, 
	stable@...r.kernel.org
Subject: Re: [PATCH] fs/ceph/mds_client: give up on paths longer than PATH_MAX

On Mon, Nov 25, 2024 at 2:24 PM Alex Markuze <amarkuze@...hat.com> wrote:
> Max, could you add a cap on the retry count to your original patch?

Before I wrote code that's not useful at all: I don't quite get why
retry on buffer overflow is necessary at all. It looks like it once
seemed to be a useful kludge, but then 1b71fe2efa31 ("ceph analog of
cifs build_path_from_dentry() race fix") added the read_seqretry()
check which, to my limited understanding, is a more robust
implementation of rename detection.

Max