linux-kernel - Re: [PATCH] of: Add Google Juniper to excluded default cells list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL6e28pZ9G55Ab6SJO_xNK1R7D-xReC8girvP9VMUk=2Q@mail.gmail.com>
Date: Mon, 25 Nov 2024 09:46:10 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Saravana Kannan <saravanak@...gle.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Sasha Levin <sashal@...nel.org>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Matthias Brugger <matthias.bgg@...il.com>, Chen-Yu Tsai <wenst@...omium.org>, 
	Conor Dooley <conor@...nel.org>
Subject: Re: [PATCH] of: Add Google Juniper to excluded default cells list

On Mon, Nov 25, 2024 at 5:32 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Google Juniper platforms have a very old bootloader which populates
> /firmware node without proper address/size-cells leading to warnings:
>
>   Missing '#address-cells' in /firmware
>   WARNING: CPU: 0 PID: 1 at drivers/of/base.c:106 of_bus_n_addr_cells+0x90/0xf0
>   Modules linked in:
>   CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.0 #1 933ab9971ff4d5dc58cb378a96f64c7f72e3454d
>   Hardware name: Google juniper sku16 board (DT)
>   ...
>   Missing '#size-cells' in /firmware
>   WARNING: CPU: 0 PID: 1 at drivers/of/base.c:133 of_bus_n_size_cells+0x90/0xf0
>   Modules linked in:
>   CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Tainted: G        W          6.12.0 #1 933ab9971ff4d5dc58cb378a96f64c7f72e3454d
>   Tainted: [W]=WARN
>   Hardware name: Google juniper sku16 board (DT)
>
> The platform won't receive updated bootloader/firmware so add it to
> excluded platform list to silence the warning.

I'm interested to know what needs these in /firmware. /firmware is
supposed to be for things without an MMIO interface. An alternative
solution is to add the properties. That doesn't require
CONFIG_OF_DYNAMIC and is often the approach powerpc uses.

I'm also wondering if ranges is also missing?

Rob