linux-kernel - Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for video hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <474cef98-4644-4838-b07c-950ad7515b73@kernel.org>
Date: Mon, 25 Nov 2024 16:55:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Renjiang Han (QUIC)" <quic_renjiang@...cinc.com>
Cc: Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 "Vikash Garodia (QUIC)" <quic_vgarodia@...cinc.com>,
 "bryan.odonoghue@...aro.org" <bryan.odonoghue@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
 "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: qcom,qcs615-venus: add support for
 video hardware

On 25/11/2024 16:49, Renjiang Han (QUIC) wrote:
>>> +  video-decoder:
>>> +    type: object
>>> +
>>> +    additionalProperties: false
>>> +
>>> +    properties:
>>> +      compatible:
>>> +        const: venus-decoder
>>> +
>>> +    required:
>>> +      - compatible
>>> +
>>> +  video-encoder:
>>> +    type: object
> 
>> Both nodes are useless - no resources here, nothing to control.
>> Do not add nodes just to instantiate Linux drivers. Drop them.
> Do you mean I should remove video-decoder and video-encoder from here?

Yes, that's my suggestion.

> If so, do I also need to remove these two nodes from the dtsi file and add

Yes

> them in the qcs615-ride.dts file?

Well, no, how would it pass dtbs_check?

Don't add nodes purely for Linux driver instantiation.

Best regards,
Krzysztof