linux-kernel - Re: [PATCH net] selftests: rds: move test.py to TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0648385f8654381778b2ceaefe3204d2726f439b.camel@oracle.com>
Date: Tue, 26 Nov 2024 20:04:32 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "liuhangbin@...il.com"
	<liuhangbin@...il.com>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Vegard Nossum
	<vegard.nossum@...cle.com>,
        Chuck Lever III <chuck.lever@...cle.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        "rds-devel@....oracle.com"
	<rds-devel@....oracle.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "mheyne@...zon.de" <mheyne@...zon.de>
Subject: Re: [PATCH net] selftests: rds: move test.py to TEST_FILES

On Sun, 2024-11-24 at 07:32 +0000, Hangbin Liu wrote:
> The test.py should not be run separately. It should be run via run.sh,
> which will do some sanity checks first. Move the test.py from TEST_PROGS
> to TEST_FILES.

This looks fine to me.  Thanks for the catch!
Reviewed-by: Allison Henderson <allison.henderson@...cle.com>

> 
> Reported-by: Maximilian Heyne <mheyne@...zon.de>
> Closes: https://lore.kernel.org/netdev/20241122150129.GB18887@dev-dsk-mheyne-1b-55676e6a.eu-west-1.amazon.com
> Fixes: 3ade6ce1255e ("selftests: rds: add testing infrastructure")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tools/testing/selftests/net/rds/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
> index 1803c39dbacb..612a7219990e 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -3,10 +3,9 @@
>  all:
>  	@echo mk_build_dir="$(shell pwd)" > include.sh
>  
> -TEST_PROGS := run.sh \
> -	test.py
> +TEST_PROGS := run.sh
>  
> -TEST_FILES := include.sh
> +TEST_FILES := include.sh test.py
>  
>  EXTRA_CLEAN := /tmp/rds_logs include.sh
>