linux-kernel - Re: [PATCH] bcache:fix oops in cache_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A86AAB66-C89A-4A37-8416-F9A99D4630D8@suse.de>
Date: Wed, 27 Nov 2024 07:45:38 +0800
From: Coly Li <colyli@...e.de>
To: liequan che <liequanche@...il.com>
Cc: "mingzhe.zou@...ystack.cn" <mingzhe.zou@...ystack.cn>,
 Kent Overstreet <kent.overstreet@...il.com>,
 linux-bcache <linux-bcache@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bcache:fix oops in cache_set_flush



> 2024年11月26日 23:38，Coly Li <colyli@...e.de> 写道：
> 
> 
> 
>> 2024年11月19日 12:19，liequan che <liequanche@...il.com> 写道：
>> 
> 
> [snipped]
> 
>>>> 7. Repartition again, triggering kernel panic again.
>>>> parted -s --align optimal /dev/nvme2n1 mkpart primary 2048s 1536GiB
>>>> The same operation was performed on the other two servers, and no
>>>> panic was triggered.
>> 
>>> I guess this is another undefine operation. I assume the cache device is still references somewhere. A reboot should follow the wipefs.
>> Your guess is correct. In addition, after erasing the superblock
>> information in CD rescue mode,
>> I rebooted into the system where the original panic kernel was located.
>> 
> 
> Please try latest upstream kernel and try whether you can see the issue.
> 
> c->root is allocated by __bch_btree_node_alloc(), it doesn’t return NULL pointer.

I need to withdraw the above inaccurate comments. It c->root cannot be NULL from __bch_btree_node_alloc(), but it can be NULL if previous lines failed and went to the error code path.

Thanks to commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations”). Could you please to compose a patch to partially revert it? The change is same, but change the commit log to mention that your change partially revert commit 028ddcac477b.


Thanks.

Coly Li