linux-kernel - Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Starmie Chromebooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGb2v655Bfx44XBPH24FKuEFTJ3ngjbAPEpNBn5vyLZfNGKt+Q@mail.gmail.com>
Date: Tue, 26 Nov 2024 12:36:08 +0800
From: Chen-Yu Tsai <wens@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Wojciech Macek <wmacek@...omium.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Chen-Yu Tsai <wenst@...omium.org>, 
	Rafal Milecki <rafal@...ecki.pl>, Hsin-Yi Wang <hsinyi@...omium.org>, 
	Sean Wang <sean.wang@...iatek.com>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Starmie Chromebooks

On Tue, Nov 26, 2024 at 2:34 AM Conor Dooley <conor@...nel.org> wrote:
>
> On Mon, Nov 25, 2024 at 08:21:28AM +0000, Wojciech Macek wrote:
> > Add an entry for the MT8186 based Starmie Chromebooks, also known as the
> > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is
> > a tablet style chromebook.
> >
> > Signed-off-by: Wojciech Macek <wmacek@...omium.org>
> > ---
> >
> > Changelog v2-v1:
> >  - Fixed items/const bidings description in mediatek.yaml
> >
> >  Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 1d4bb50fcd8d9..6191a5320c148 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -263,6 +263,19 @@ properties:
> >            - const: google,steelix-sku196608
> >            - const: google,steelix
> >            - const: mediatek,mt8186
> > +      - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001))
> > +        items:
> > +          - const: google,starmie-sku0
> > +          - const: google,starmie-sku2
> > +          - const: google,starmie-sku3
>
> Compatible order here is back to making little sense. Why is the oldest
> SKU, in both cases, appearing first?

FWIW the SKU number has no particular ordering. They were released together.
SKU denotes different configurations (memory, storage, touchscreen and other
component options). OOTH revisions would actually have chronological meaning.


ChenYu

> > +          - const: google,starmie
> > +          - const: mediatek,mt8186
> > +      - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001))
> > +        items:
> > +          - const: google,starmie-sku1
> > +          - const: google,starmie-sku4
> > +          - const: google,starmie
> > +          - const: mediatek,mt8186
> >        - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4)
> >          items:
> >            - enum:
> > --
> > 2.47.0.371.ga323438b13-goog
> >