linux-kernel - Re: [PATCH net] net/l2tp: fix warning in l2tp_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173261162982.313261.16721245294644686761.git-patchwork-notify@kernel.org>
Date: Tue, 26 Nov 2024 09:00:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: James Chapman <jchapman@...alix.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 guohui.study@...il.com, horms@...nel.org, kuba@...nel.org,
 linux-kernel@...r.kernel.org, pabeni@...hat.com,
 syzkaller-bugs@...glegroups.com,
 syzbot+332fe1e67018625f63c9@...kaller.appspotmail.com, tparkin@...alix.com
Subject: Re: [PATCH net] net/l2tp: fix warning in l2tp_exit_net found by syzbot

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Mon, 18 Nov 2024 14:04:11 +0000 you wrote:
> In l2tp's net exit handler, we check that an IDR is empty before
> destroying it:
> 
> 	WARN_ON_ONCE(!idr_is_empty(&pn->l2tp_tunnel_idr));
> 	idr_destroy(&pn->l2tp_tunnel_idr);
> 
> By forcing memory allocation failures in idr_alloc_32, syzbot is able
> to provoke a condition where idr_is_empty returns false despite there
> being no items in the IDR. This turns out to be because the radix tree
> of the IDR contains only internal radix-tree nodes and it is this that
> causes idr_is_empty to return false. The internal nodes are cleaned by
> idr_destroy.
> 
> [...]

Here is the summary with links:
  - [net] net/l2tp: fix warning in l2tp_exit_net found by syzbot
    https://git.kernel.org/netdev/net/c/5d066766c5f1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html