linux-kernel - Re: [PATCH] wifi: brcmfmac: remove misleading log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be2f054e-5ff8-4fcb-ad50-0dc0d5c03bf5@broadcom.com>
Date: Tue, 26 Nov 2024 12:02:05 +0100
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Alex Shumsky <alexthreed@...il.com>, linux-wireless@...r.kernel.org
Cc: Al Viro <viro@...iv.linux.org.uk>, Kalle Valo <kvalo@...nel.org>,
 brcm80211-dev-list.pdl@...adcom.com, brcm80211@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: remove misleading log messages

On 11/22/2024 7:04 PM, Alex Shumsky wrote:
> Currently when debug info enabled, dmesg spammed every few minutes with
> misleading messages like:
>    brcmf_netdev_start_xmit phy0-sta0: insufficient headroom (0)
> 
> Do not log this when headroom is actually sufficient.

Thanks for your patch. The message may be misleading, but it is actually 
information that we need to cow the packet. The zero value indicates 
that this is needed because skb_header_cloned(skb) is true. So it is 
still useful in my opinion. If you want to make the message less 
misleading for that case I would be happy to ack the patch.

Regards,
Arend