linux-kernel - Re: [PATCH] brcmfmac: fix RSSI report in AP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <980c5cee-2dc3-4d26-b749-6ba00b9c2091@broadcom.com>
Date: Tue, 26 Nov 2024 12:13:44 +0100
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Alex Shumsky <alexthreed@...il.com>, linux-wireless@...r.kernel.org
Cc: Alexey Berezhok <a@...repo.ru>, Alvin Šipraga
 <ALSI@...g-olufsen.dk>, Hector Martin <marcan@...can.st>,
 Janne Grunau <j@...nau.net>, Kalle Valo <kvalo@...nel.org>,
 Kees Cook <kees@...nel.org>, Neal Gompa <neal@...pa.dev>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 brcm80211-dev-list.pdl@...adcom.com, brcm80211@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] brcmfmac: fix RSSI report in AP mode

On 11/22/2024 10:03 PM, Alex Shumsky wrote:
> After commit 9a1590934d9a ("brcmfmac: correctly report average RSSI in
> station info") it is required from firmware to provide rx_lastpkt_rssi.
> If this field is not provided brcmfmac doesn't report any RSSI at all.
> Unfortunately some firmwares doesn't provide it. One example is firmware
> for BCM43455 found in Raspbberry Pi.
> See https://github.com/raspberrypi/linux/issues/4574
> 
> Fix it by falling back to rssi field if rx_lastpkt_rssi is not provided
> (like it was before 9a1590934d9a).

Sounds like a reasonable approach. However, I would like to learn more 
about the issue. Maybe it is a per-vendor issue so I am interested what 
the sta_info version is that we get from firmware. It is printed in 
brcmf_cfg80211_get_station() with brcmf_dbg(). You can make it a 
bphy_err() call instead or enable TRACE level debug messages in the driver.

Also would be good to know the firmware version and kernel version of 
the BCM43455.

Regards,
Arend