linux-kernel - Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8186: Add Starmie device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473283aa-fc84-4b3f-93bc-653c9d83c837@collabora.com>
Date: Tue, 26 Nov 2024 12:35:26 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Wojciech Macek <wmacek@...omium.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Chen-Yu Tsai <wenst@...omium.org>, Rafal Milecki <rafal@...ecki.pl>,
 Hsin-Yi Wang <hsinyi@...omium.org>, Sean Wang <sean.wang@...iatek.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 2/2] arm64: dts: mediatek: mt8186: Add Starmie device

Il 26/11/24 11:36, Wojciech Macek ha scritto:
> Add support for Starmie Chromebooks.
> 
> Signed-off-by: Wojciech Macek <wmacek@...omium.org>
> ---
> Changelog v3-v2:
>   - Cleaned up DTS
>     - Re-using dsi_out node
>     - Removed unnecessary delete-nodes
>     - Moved touchpads to per-board dts
>     - Modified 3.3/6V power regulator node
> Changelog v2-v1:
>   - No changes
>   arch/arm64/boot/dts/mediatek/Makefile         |   2 +
>   .../mediatek/mt8186-corsola-starmie-sku0.dts  |  31 ++
>   .../mediatek/mt8186-corsola-starmie-sku1.dts  |  31 ++
>   .../dts/mediatek/mt8186-corsola-starmie.dtsi  | 465 ++++++++++++++++++
>   4 files changed, 529 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie-sku0.dts
>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie-sku1.dts
>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-starmie.dtsi
> 

..snip..
> +/*
> + * Battery on Starmie is using a different address than default.
> + */
> +&battery {

I didn't ask you to do it this way, and that was for a good reason.

Besides, you haven't run dtbs_check before sending this.
Give it a go and you'll see why.

Regards,
Angelo

> +	reg = <0xf>;
> +};