linux-kernel - Re: [cocci] [PATCH 01/11] coccinelle: Add script to reorder capable() calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e49861c-123d-4d78-9da7-bdf747c9c33a@web.de>
Date: Tue, 26 Nov 2024 13:55:36 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Christian Göttsche <cgzones@...glemail.com>,
 linux-security-module@...r.kernel.org, cocci@...ia.fr,
 Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas Palix <nicolas.palix@...g.fr>,
 Serge Hallyn <serge@...lyn.com>
Cc: Christian Göttsche <cgoettsche@...tendoof.de>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [cocci] [PATCH 01/11] coccinelle: Add script to reorder capable()
 calls

…
> +(
> +-  F@p(EL) op E
> ++  E op F(EL)
> +|
> +-  E1 op1 F@p(EL) op2 E2
> ++  E1 op1 E2 op2 F(EL)
> +)

How do you think about to use an SmPL code variant like the following?

(
 E1 op1
-F@p(EL)
+E2
 op2
-E2
+F(EL)
|
-F@p(EL) op
 E
+op F(EL)
)


> +//----------------------------------------------------------
> +//  For context mode
> +//----------------------------------------------------------
> +
> +@r1 depends on !patch exists@
…

I would prefer the dependency specification “context” for this SmPL rule.
The SmPL asterisk functionality should be better distinguished here.


…
> +@...ipt:python depends on org@
> +p << r1.p;
> +@@
…

I got the impression that source code search approaches can be safely
shared only between the operation modes “org” and “report” so far.

Regards,
Markus