linux-kernel - Re: [PATCH 3/3] spi: spidev: add "tegra-spidev" name string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d286a32-a76d-493b-88e6-4c652441258b@kernel.org>
Date: Tue, 26 Nov 2024 15:02:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vishwaroop A <va@...dia.com>, robh@...nel.org, jonathanh@...dia.com,
 krzk+dt@...nel.org, conor+dt@...nel.org, thierry.reding@...il.com,
 broonie@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
 linux-spi@...r.kernel.org
Subject: Re: [PATCH 3/3] spi: spidev: add "tegra-spidev" name string

On 26/11/2024 14:45, Vishwaroop A wrote:
> Add "tegra-spidev" name string to load spidev driver
> which allows user-space programs to access and communicate
> with SPI devices connected to the system.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Vishwaroop A <va@...dia.com>
> ---
>  drivers/spi/spidev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
> index 653f82984216..1d2c01bd76a9 100644
> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -711,6 +711,7 @@ static const struct spi_device_id spidev_spi_ids[] = {
>  	{ .name = "spi-authenta" },
>  	{ .name = "em3581" },
>  	{ .name = "si3210" },
> +	{ .name = "tegra-spidev" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(spi, spidev_spi_ids);
> @@ -741,6 +742,7 @@ static const struct of_device_id spidev_dt_ids[] = {
>  	{ .compatible = "semtech,sx1301", .data = &spidev_of_check },
>  	{ .compatible = "silabs,em3581", .data = &spidev_of_check },
>  	{ .compatible = "silabs,si3210", .data = &spidev_of_check },
> +	{ .compatible = "nvidia,tegra-spidev", .data = &spidev_of_check },

That's too generic. You need to come with compatibles matching exactly
the device connected.

Above comment applies to all your patches here - DTS and bindings as well.

Best regards,
Krzysztof