linux-kernel - Re: [PATCH v7 0/2] Support for Texas Instruments OPT4060 RGBW Color sensor.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c5929f6-6210-4b36-95ef-79bc7028b351@kernel.org>
Date: Tue, 26 Nov 2024 15:15:00 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Per-Daniel Olsson <perdaniel.olsson@...s.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, rickard.andersson@...s.com, kernel@...s.com
Subject: Re: [PATCH v7 0/2] Support for Texas Instruments OPT4060 RGBW Color
 sensor.

On 26/11/2024 15:00, Per-Daniel Olsson wrote:
> This patch series adds support for Texas Instruments OPT4060 RGBW Color sensor
> using the i2c interface.
> 
> The driver exposes raw adc values for red, green, blue and clear. The
> illuminance is exposed as a calculated value in lux, the calculation uses the
> wide spectrum green channel as base. The driver supports scaled values for red,
> green and blue. The raw values are scaled so that for a particular test light
> source, typically white, the measurement intensity is the same across the
> different color channels. Integration time can be configured through sysfs as
> well. The OPT4060 sensor supports both rising and falling threshold interrupts.
> These interrupts are exposed as IIO events. The driver also implements an IIO
> triggered buffer with a trigger for conversion ready interrupts.
> 
> Changes in v7:
> - Calculation for scaled values changed to remove normalization.
> - Fixed alignment in opt4060_write_ev_period(...).
> - Fixed alignment in opt4060_read_ev_period(...).
> - Updates state to bool in opt4060_write_event_config(...).
> - dt-bindings: Define vdd-supply as required.
> - dt-bindings: Removed description of vdd-supply.
> - dt-bindings: Removed "Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>"
>   due to changes.
This is a bug surprise. Because you dropped description of vdd-supply?
No, that's not a reason to request a re-review.

Please read submitting patches document.

Keep the tag. I really do not expect more changes to the binding at
point of v6 or v7, especially ones so serious that result in dropping tags.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof