linux-kernel - Re: [PATCH 1/2] debugfs: add small file operations for most files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41242bd65b27736f6dc0115d2ad2422d5b157d23.camel@sipsolutions.net>
Date: Tue, 26 Nov 2024 15:22:15 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Alexander Viro
 <viro@...iv.linux.org.uk>, "Rafael J . Wysocki" <rafael@...nel.org>,
 linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: [PATCH 1/2] debugfs: add small file operations for most files

On Tue, 2024-11-26 at 15:16 +0100, Geert Uytterhoeven wrote:
> 
> Assuming non-wireless drivers can be converted, too?  As none of the
> classical m68k machines support wireless, so far nothing is gained...

Oh, most debugfs files can be converted, since most don't do anything
beyond simple_open/read/write/seek and those are covered.

> > Unfortunately this requires another set of full file ops,
> > increasing the size by 536 bytes (x86-64), but that's still
> 
> 226 on m68k.

Not that bad, I guess. So if that's 226 bytes and before you had 447
we'd probably only need to convert 4 instances to have a net win :)

> Thanks, that fixed the issue!
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Great, thanks for testing!

I'll do some more testing of my own and then figure out how to get it
into the tree. Greg, any thoughts on that?

johannes