lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DDB8CFE4-D53C-456B-847D-5190053FA478@nvidia.com>
Date: Tue, 26 Nov 2024 09:38:06 -0500
From: Zi Yan <ziy@...dia.com>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, David Hildenbrand <david@...hat.com>,
 Ritesh Harjani <ritesh.list@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>
Subject: Re: [PATCH] Removed unused argument vma from migrate_misplaced_folio

On 25 Nov 2024, at 2:57, Donet Tom wrote:

> Commit ee86814b0562 ("mm/migrate: move NUMA hinting fault folio
> isolation + checks under PTL") removed the code that had used
> the vma argument in migrate_misplaced_folio.
>
> Since the vma argument was no longer used in migrate_misplaced_folio,
> this patch removed it.
>
> Signed-off-by: Donet Tom <donettom@...ux.ibm.com>
> ---
>  include/linux/migrate.h | 6 ++----
>  mm/huge_memory.c        | 2 +-
>  mm/memory.c             | 2 +-
>  mm/migrate.c            | 3 +--
>  4 files changed, 5 insertions(+), 8 deletions(-)

Like Baolin suggested in another email, "mm/migrate:" prefix should be
used. Otherwise, LGTM. Thanks. Reviewed-by: Zi Yan <ziy@...dia.com>

--
Best Regards,
Yan, Zi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ