linux-kernel - Re: [PATCH v2 4/6] dt-bindings: clock: imx8mp: Add syscon compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAVmza+A5QC1Xq4dsw1WBtdp0EoM505+UzrCKe15+vqhA@mail.gmail.com>
Date: Tue, 26 Nov 2024 17:31:21 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Daniel Baluta <daniel.baluta@....com>, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	kernel@...gutronix.de, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, festevam@...il.com, devicetree@...r.kernel.org, 
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, aisheng.dong@....com, 
	laurentiu.mihalcea@....com, shengjiu.wang@....com, iuliana.prodan@....com, 
	a.fatoum@...gutronix.de
Subject: Re: [PATCH v2 4/6] dt-bindings: clock: imx8mp: Add syscon compatible

On Mon, Nov 25, 2024 at 7:08 PM Frank Li <Frank.li@....com> wrote:
>
> On Mon, Nov 25, 2024 at 05:24:24PM +0200, Daniel Baluta wrote:
> > imx8mp audiomix contains a set of registers used to control
> > the DSP.
> >
> > The dsp will use this to acquire o reference to audiomix registers
> > and handle the registers to control the dsp.
>
> Look like this is NOT good method to direct operate these register. If it
> is reset, you should export it as reset interface. If it is clock, you
> should export it as clock interface.


Hi Frank,

The code to handle this is already upstream and used for:

Remoteproc

https://elixir.bootlin.com/linux/v6.12/source/drivers/remoteproc/imx_dsp_rproc.c#L991

and Sound Open Firmware

https://elixir.bootlin.com/linux/v6.12/source/sound/soc/sof/imx/imx8m.c#L237

I'm not sure if it worths the effort to refactor this for such a
simple operation.