| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <050d1398-cfc2-4921-b82a-95eecbcddba4@kernel.org>
Date: Tue, 26 Nov 2024 17:46:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: fnkl.kernel@...il.com, Hector Martin <marcan@...can.st>,
Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
Jessica Zhang <quic_jesszhan@...cinc.com>, asahi@...ts.linux.dev
Cc: linux-arm-kernel@...ts.infradead.org, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: display: Add Apple pre-DCP display
controller bindings
On 26/11/2024 17:34, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.kernel@...il.com>
>
> Add bindings for a secondary display controller present on certain
> Apple laptops.
>
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
> .../display/apple,h7-display-pipe-mipi.yaml | 89 ++++++++++++++++++++++
> .../bindings/display/apple,h7-display-pipe.yaml | 77 +++++++++++++++++++
> .../bindings/display/panel/apple,summit.yaml | 58 ++++++++++++++
> 3 files changed, 224 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml b/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..2cf2f50e9fc7329a5b424d5ddf8c34cad2ebb6be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/apple,h7-display-pipe-mipi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple pre-DCP display controller MIPI interface.
Drop final stop, that's a title so it could be capitalized, but anyway
it is not a sentence
> +
> +maintainers:
> + - asahi@...ts.linux.dev
Drop, maintainer boxes are not allowed for bindings.
> + - Sasha Finkelstein <fnkl.kernel@...il.com>
> +
> +description:
> + The MIPI controller part of the pre-DCP Apple display controller
> +
> +allOf:
> + - $ref: dsi-controller.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t8112-display-pipe-mipi
> + - apple,t8103-display-pipe-mipi
> + - const: apple,h7-display-pipe-mipi
> +
> + reg:
> + maxItems: 1
> +
> + reg-names:
> + const: mipi
> +
> + power-domains:
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> + required:
> + - port@0
> + - port@1
Please take a look how other bindings define ports. You miss here
several items and more important - description what are these ports for.
> +
> + '#address-cells': true
> +
> + '#size-cells': true
> +
> +patternProperties:
> + "^panel@[0-3]$": true
These look unusual. Is this a DSI controller? If so, then reference
dsi-controller. See other bindings how this is done.
> +
> +required:
> + - compatible
> + - reg
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + display_dfr: dsi@...200000 {
Drop unused label
> + compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi";
> + reg-names = "mipi";
> + reg = <0x28200000 0xc000>;
Order fields according to DTS coding style.
> + power-domains = <&ps_dispdfr_mipi>;
> +
> + ports {
> + #address-cells = <1>;
Messed indentation. Use 4 spaces for example indentation.
> + #size-cells = <0>;
> +
> + dfr_mipi_in: port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + };
> +
> + dfr_mipi_out: port@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + };
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..98982da9c5f672167d67e4cd3b47e1fbdafc9510
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/apple,h7-display-pipe.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple pre-DCP display controller.
> +
> +maintainers:
> + - asahi@...ts.linux.dev
> + - Sasha Finkelstein <fnkl.kernel@...il.com>
> +
> +description:
> + A secondary display controller used to drive the "touchbar" on certain Apple laptops.
Please wrap code according to coding style (checkpatch is not a coding
style description, but only a tool).
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,t8112-display-pipe
> + - apple,t8103-display-pipe
> + - const: apple,h7-display-pipe
> +
> + reg:
> + maxItems: 2
List and describe the items instead, because be and fe are a bit cryptic.
> +
> + reg-names:
> + items:
> + - const: be
> + - const: fe
> +
> + power-domains:
> + maxItems: 2
Need to list the items instead.
> +
> + interrupts:
> + maxItems: 2
Ditto
> +
> + interrupt-names:
> + items:
> + - const: be
> + - const: fe
> +
> + iommus:
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/apple-aic.h>
> + display_dfr: display-pipe@...200000 {
Drop unused label.
> + compatible = "apple,t8103-display-pipe", "apple,h7-display-pipe";
> + reg-names = "be", "fe";
> + reg = <0x28200000 0xc000>,
> + <0x28400000 0x4000>;
Messed alignment, in other places as well.
> + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>;
> + interrupt-parent = <&aic>;
> + interrupts = <AIC_IRQ 502 IRQ_TYPE_LEVEL_HIGH>,
> + <AIC_IRQ 506 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "be", "fe";
> + iommus = <&displaydfr_dart 0>;
> + port {
> + dfr_adp_out_mipi: endpoint {
Messed indentation.
> + remote-endpoint = <&dfr_mipi_in_adp>;
> + };
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/display/panel/apple,summit.yaml b/Documentation/devicetree/bindings/display/panel/apple,summit.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..db14f7af3787076c84ccdda08fedeb8912d5514d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/apple,summit.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/apple,summit.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple "Summit" display panel.
> +
> +maintainers:
> + - asahi@...ts.linux.dev
> + - Sasha Finkelstein <fnkl.kernel@...il.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/leds/backlight/common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,j293-summit
> + - apple,j493-summit
> + - const: apple,summit
Summit tells me nothing - no description, title repeats it, so I suggest
using device specific compatible.
> +
> + reg:
> + maxItems: 1
> +
> + max-brightness: true
> +
> + port: true
No, these cannot be true without definition. Again, please open existing
bindings and use them as example. You probably miss here some reference,
but max-brightness for panel is a bit confusing. I asked already and did
not get answer: isn't this backlight property? What is this device -
backlight or panel? If panel, then what bus?
Best regards,
Krzysztof
Powered by blists - more mailing lists