linux-kernel - Re: [PATCH v3 24/26] media: venus: venc: Make the range of us_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiDSCufyxGARwe1haE6r46B0LZE6tgUV=iG6OyJuY0mr38bvg@mail.gmail.com>
Date: Tue, 26 Nov 2024 18:47:38 +0100
From: Ricardo Ribalda <ribalda@...omium.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...all.nl>, 
	Stanimir Varbanov <svarbanov@...e.de>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 24/26] media: venus: venc: Make the range of
 us_per_frame explicit

Stanimir :

Ping!
(also for https://patchwork.linuxtv.org/project/linux-media/patch/20240429-fix-cocci-v3-23-3c4865f5a4b0@chromium.org/
)

Thanks!

On Mon, 29 Apr 2024 at 17:05, Ricardo Ribalda <ribalda@...omium.org> wrote:
>
> Unless the fps is smaller than 0.000232829 fps, this fits in a 32 bit
> number. Make that explicit.
>
> Found with cocci:
> drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> ---
>  drivers/media/platform/qcom/venus/venc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 3ec2fb8d9fab..f87e33a34610 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -393,7 +393,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
>         struct venus_inst *inst = to_inst(file);
>         struct v4l2_outputparm *out = &a->parm.output;
>         struct v4l2_fract *timeperframe = &out->timeperframe;
> -       u64 us_per_frame, fps;
> +       u64 us_per_frame;
>
>         if (a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT &&
>             a->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> @@ -414,11 +414,8 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
>         if (!us_per_frame)
>                 return -EINVAL;
>
> -       fps = (u64)USEC_PER_SEC;
> -       do_div(fps, us_per_frame);
> -
> +       inst->fps = USEC_PER_SEC / (u32)us_per_frame;
>         inst->timeperframe = *timeperframe;
> -       inst->fps = fps;
>
>         return 0;
>  }
>
> --
> 2.44.0.769.g3c40516874-goog
>


-- 
Ricardo Ribalda