linux-kernel - Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2a8984f-e67f-4e29-93ed-32d908ffef58@quicinc.com>
Date: Tue, 26 Nov 2024 23:29:05 +0530
From: Yuvaraj Ranganathan <quic_yrangana@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Krzysztof Kozlowski <krzk@...nel.org>,
        Herbert Xu
	<herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "Konrad Dybcio" <konradybcio@...nel.org>,
        Vinod Koul <vkoul@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH V4 2/2] arm64: dts: qcom: qcs8300: add TRNG node

On 11/26/2024 4:05 AM, Dmitry Baryshkov wrote:
> On Sun, Nov 24, 2024 at 09:17:40AM +0530, Yuvaraj Ranganathan wrote:
>> Hi Krzysztof,
>>
>> I sincerely apologize for the inconvenience. I added the "Reviewed-by"
>> tag without fully understanding its implications. I will remove the tag
>> in the next patch series.
> 
> First of all, please don't top-post. Put your text under the phrases
> that you are responding to, not at the top of the message. Otherwise the
> logic is a bit broken.
> 
> Second, may I ask, what made you add that tag at all? I went on and
> checked. Krzysztof didn't repond at all to v3 and didn't respond to v2
> of this patch. So why?
> 
> Third, if you are unsure about what you are doing and as you seem to be
> using b4 tool, please just use `b4 trailers -u`. It has its own
> drawbacks so in some cases one should be careful, but at least it
> doesn't invent tags on its own.
> 
>>
>> Thanks,
>> Yuvaraj.
>>
>> On 11/22/2024 8:30 PM, Krzysztof Kozlowski wrote:
>>> On 22/11/2024 08:43, Yuvaraj Ranganathan wrote:
>>>> The qcs8300 SoC has a True Random Number Generator, add the node with
>>>> the correct compatible set.
>>>>
>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@...nel.org>
>>>
>>> NAK, stop adding fake tags. It is impossible to receive above tag from
>>> me written that way.
>>>
>>> Best regards,
>>> Krzysztof
>>
> 

I've added the "Reviewed-by" tag without a proper understanding as I got
few comments
(https://lore.kernel.org/all/4009f4ee-2c55-4a4f-8805-eafe7efc0147@kernel.org/)
 on the earlier patches and tagged the reviewers under "Reviewed-by". I
sincerely apologize on this and will ensure to avoid such mistakes in
future.

Thanks,
Yuvaraj.