linux-kernel - Re: [PATCH 0/9] Add support for Software mode on AD7606's iio backend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241126180035.4a2afb01@jic23-huawei>
Date: Tue, 26 Nov 2024 18:00:35 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Guillaume Stols <gstols@...libre.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nuno Sa <nuno.sa@...log.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, dlechner@...libre.com, jstephan@...libre.com,
 aardelean@...libre.com, adureghello@...libre.com
Subject: Re: [PATCH 0/9] Add support for Software mode on AD7606's iio
 backend driver

On Thu, 21 Nov 2024 10:18:22 +0000
Guillaume Stols <gstols@...libre.com> wrote:

> This series adds the support for software mode when the ADC is used in
> iio_backend mode.

I'm not sure form this description what "software mode" means.

Perhaps some more info on that for v2?

> The bus access is based on Angelo's ad3552 implementation, that is we
> have a particular compatible for the backend (here axi-adc) version
> supporting the ad7606's register writing, and the ad7606 is defined as a
> child node of the backend in the devicetree.
> Small changes are added to make the code a bit more straightforward to
> understand, and more compact.
> 
> Signed-off-by: Guillaume Stols <gstols@...libre.com>
> ---
> Guillaume Stols (9):
>       iio: adc: ad7606: Fix hardcoded offset in the ADC channels
>       dt-bindings: iio: dac: adi-axi-adc: Add ad7606 variant
>       iio:adc: ad7606: Move the software mode configuration
>       iio: adc: ad7606: Move software functions into common file
>       iio: adc: adi-axi-adc: Add platform children support
>       iio: adc: adi-axi-adc: Add support for AD7606 register writing
>       iio: adc: ad7606: change r/w_register signature
>       iio: adc: ad7606: Simplify channel macros
>       iio: adc: ad7606: Add support for writing registers when using backend
> 
>  .../devicetree/bindings/iio/adc/adi,axi-adc.yaml   |   7 +
>  drivers/iio/adc/ad7606.c                           | 202 +++++++++++++++++----
>  drivers/iio/adc/ad7606.h                           | 113 ++++++++----
>  drivers/iio/adc/ad7606_bi.h                        |  16 ++
>  drivers/iio/adc/ad7606_par.c                       |  58 +++++-
>  drivers/iio/adc/ad7606_spi.c                       | 141 +-------------
>  drivers/iio/adc/adi-axi-adc.c                      | 178 +++++++++++++++++-
>  7 files changed, 500 insertions(+), 215 deletions(-)
> ---
> base-commit: 33d38f912d5ca05501c9bbfe14e0150da9ca85b6
> change-id: 20241009-ad7606_add_iio_backend_software_mode-567d9c392243
> 
> Best regards,
> --
> Guillaume Stols <gstols@...libre.com>
> 
>