linux-kernel - Re: [External] : Re: [bug-report] 5-9% FIO randomwrite ext4 perf regression on 6.12.y kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D00AC7C8-8371-4629-BA39-E0BFB9975195@oracle.com>
Date: Tue, 26 Nov 2024 18:06:19 +0000
From: Saeed Mirzamohammadi <saeed.mirzamohammadi@...cle.com>
To: Christoph Hellwig <hch@....de>
CC: Keith Busch <kbusch@...nel.org>, Paul Webb <paul.x.webb@...cle.com>,
        Jens
 Axboe <axboe@...nel.dk>, Phil Auld <pauld@...hat.com>,
        Chaitanya Kulkarni
	<chaitanyak@...dia.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>,
        Ramanan Govindarajan
	<ramanan.govindarajan@...cle.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Nicky
 Veitch <nicky.veitch@...cle.com>
Subject: Re: [External] : Re: [bug-report] 5-9% FIO randomwrite ext4 perf
 regression on 6.12.y kernel

I was waiting for the results but yes that recovered the regression as well (snippet below), thanks! I think that’s the best way to go here. Should I make it into a patch and send it for review?

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 983909a600adb..d252c9651fc99 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2044,7 +2044,7 @@ static bool nvme_update_disk_info(struct nvme_ns *ns, struct nvme_id_ns *id,
        lim->physical_block_size = min(phys_bs, atomic_bs);
        lim->io_min = phys_bs;
        lim->io_opt = io_opt;
-       if (ns->ctrl->quirks & NVME_QUIRK_DEALLOCATE_ZEROES)
+       if ((ns->ctrl->quirks & NVME_QUIRK_DEALLOCATE_ZEROES) && (ns->ctrl->oncs & NVME_CTRL_ONCS_DSM))
                lim->max_write_zeroes_sectors = UINT_MAX;
        else
                lim->max_write_zeroes_sectors = ns->ctrl->max_zeroes_sectors;


Saeed

> On Nov 25, 2024, at 8:55 PM, Christoph Hellwig <hch@....de> wrote:
> 
> Hi Saeed,
> 
> can you please also test I sent yesterday?
>