linux-kernel - Re: [PATCH v10 3/8] x86/resctrl: Modify update_mba_bw() to use per CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6258f96-9d8a-489e-a9e3-3dae9ecfe513@intel.com>
Date: Tue, 26 Nov 2024 10:33:18 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>, "Peter
 Newman" <peternewman@...gle.com>, Jonathan Corbet <corbet@....net>,
	<x86@...nel.org>
CC: James Morse <james.morse@....com>, Jamie Iles <quic_jiles@...cinc.com>,
	Babu Moger <babu.moger@....com>, Randy Dunlap <rdunlap@...radead.org>,
	"Shaopeng Tan (Fujitsu)" <tan.shaopeng@...itsu.com>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v10 3/8] x86/resctrl: Modify update_mba_bw() to use per
 CTRL_MON group event

Hi Tony,

On 11/22/24 3:58 PM, Tony Luck wrote:
> Update_mba_bw() hard codes use of the memory bandwidth local event which

Update_mba_bw() -> update_mba_bw()

> prevents more flexible options from being deployed.
> 
> Change this function to use the event specified in the rdtgroup that is
> being processed.
> 
> Mount time checks for the "mba_MBps" option ensure that local memory
> bandwidth is enabled. So drop the redundant is_mbm_local_enabled() check.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

With typo fixed:
| Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette