linux-kernel - Re: [PATCH v4 3/3] rust: error: Replace pr_warn by pr_warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OCjLJ1h--F-9@tuta.io>
Date: Wed, 27 Nov 2024 21:39:00 +0100 (CET)
From: jens.korinth@...a.io
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Rust For Linux <rust-for-linux@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@...il.com>,
	Dirk Behme <dirk.behme@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] rust: error: Replace pr_warn by pr_warn_once

> I would mention here the merits between `pr_warn_once` vs. `WARN_ONCE`
> and why the former was picked in this patch (especially since the
> `TODO` suggests the latter).

Tbh, I am not 100% whether this should be here at all. The bug is not here, it's
at the call site. It should probably be a `try_from` instead, to raise the error
there?

Jens