linux-kernel - Re: [GIT PULL] Modules changes for v6.13-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjCkJsdLageTx6C4n--aYFoO6gSRe0Rwcbk1jQdOdiPfg@mail.gmail.com>
Date: Wed, 27 Nov 2024 13:22:37 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: samitolvanen@...gle.com, petr.pavlu@...e.com, da.gomez@...sung.com, 
	linux-modules@...r.kernel.org, patches@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, masahiroy@...nel.org, mmaurer@...gle.com, 
	arnd@...db.de, deller@....de, song@...nel.org
Subject: Re: [GIT PULL] Modules changes for v6.13-rc1

On Tue, 26 Nov 2024 at 17:10, Luis Chamberlain <mcgrof@...nel.org> wrote:
>
> Highlights for this merge window:

Lowlights:

>   * Adds a new modules selftests: kallsyms which helps us tests find_symbol()
>     and the limits of kallsyms on Linux today.

This is completely broken.

Try doing "make allmodconfig" and then do "make" twice in a row.

It re-generates the tests, so you see this:

  GEN     lib/tests/module/test_kallsyms_a.c
  GEN     lib/tests/module/test_kallsyms_b.c
  GEN     lib/tests/module/test_kallsyms_c.c
  GEN     lib/tests/module/test_kallsyms_d.c
  CC [M]  lib/tests/module/test_kallsyms_a.o
  CC [M]  lib/tests/module/test_kallsyms_b.o
  CC [M]  lib/tests/module/test_kallsyms_c.o
  CC [M]  lib/tests/module/test_kallsyms_d.o
  LD [M]  lib/tests/module/test_kallsyms_a.ko
  LD [M]  lib/tests/module/test_kallsyms_b.ko
  LD [M]  lib/tests/module/test_kallsyms_c.ko
  LD [M]  lib/tests/module/test_kallsyms_d.ko

both times, and this has made the empty build slow down by about a
factor of two.

Which is a big deal, because the "empty build" is actually fairly
important for me. It's the baseline build test performance, and with
small pulls it actually dominates.

So this isn't ok. Please fix asap, because otherwise I will just
revert it - it really does affect my workflow that much.

                  Linus