linux-kernel - RE: [PATCH v2] scsi: storvsc: Do not flag MAINTENANCE_IN return of SRB_STATUS_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB41578E632973F20E13989BFFD4282@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Wed, 27 Nov 2024 22:37:04 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Cathy Avery <cavery@...hat.com>, "kys@...rosoft.com" <kys@...rosoft.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "haiyangz@...rosoft.com"
	<haiyangz@...rosoft.com>, "decui@...rosoft.com" <decui@...rosoft.com>,
	"jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>
CC: "bhull@...hat.com" <bhull@...hat.com>, "emilne@...hat.com"
	<emilne@...hat.com>, "loberman@...hat.com" <loberman@...hat.com>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>
Subject: RE: [PATCH v2] scsi: storvsc: Do not flag MAINTENANCE_IN return of
 SRB_STATUS_DATA_OVERRUN as an error

From: Cathy Avery <cavery@...hat.com> Sent: Wednesday, November 27, 2024 10:13 AM
> 
> This patch partially reverts
> 
> 	commit 812fe6420a6e789db68f18cdb25c5c89f4561334
> 	Author: Michael Kelley <mikelley@...rosoft.com>
> 	Date:   Fri Aug 25 10:21:24 2023 -0700
> 
> 	scsi: storvsc: Handle additional SRB status values
> 
> HyperV does not support MAINTENANCE_IN resulting in FC passthrough
> returning the SRB_STATUS_DATA_OVERRUN value. Now that
> SRB_STATUS_DATA_OVERRUN
> is treated as an error multipath ALUA paths go into a faulty state as multipath
> ALUA submits RTPG commands via MAINTENANCE_IN.
> 
> [    3.215560] hv_storvsc 1d69d403-9692-4460-89f9-a8cbcc0f94f3:
> tag#230 cmd 0xa3 status: scsi 0x0 srb 0x12 hv 0xc0000001
> [    3.215572] scsi 1:0:0:32: alua: rtpg failed, result 458752
> 
> MAINTENANCE_IN now returns success to avoid the error path as
> is currently done with INQUIRY and MODE_SENSE.
> 
> Suggested-by: Michael Kelley <mhklinux@...look.com>
> Signed-off-by: Cathy Avery <cavery@...hat.com>
> ---
> Changes since v1:
> - Handle error and logging by returning success as previously
>   done with INQUIRY and MODE_SENSE [Michael Kelley].
> ---
>  drivers/scsi/storvsc_drv.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 7ceb982040a5..d0b55c1fa908 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -149,6 +149,8 @@ struct hv_fc_wwn_packet {
>  */
>  static int vmstor_proto_version;
> 
> +static bool hv_dev_is_fc(struct hv_device *hv_dev);
> +
>  #define STORVSC_LOGGING_NONE	0
>  #define STORVSC_LOGGING_ERROR	1
>  #define STORVSC_LOGGING_WARN	2
> @@ -1138,6 +1140,7 @@ static void storvsc_on_io_completion(struct storvsc_device
> *stor_device,
>  	 * not correctly handle:
>  	 * INQUIRY command with page code parameter set to 0x80
>  	 * MODE_SENSE command with cmd[2] == 0x1c
> +	 * MAINTENANCE_IN is not supported by HyperV FC passthrough
>  	 *
>  	 * Setup srb and scsi status so this won't be fatal.
>  	 * We do this so we can distinguish truly fatal failues
> @@ -1145,7 +1148,9 @@ static void storvsc_on_io_completion(struct storvsc_device
> *stor_device,
>  	 */
> 
>  	if ((stor_pkt->vm_srb.cdb[0] == INQUIRY) ||
> -	   (stor_pkt->vm_srb.cdb[0] == MODE_SENSE)) {
> +	   (stor_pkt->vm_srb.cdb[0] == MODE_SENSE) ||
> +	   (stor_pkt->vm_srb.cdb[0] == MAINTENANCE_IN &&
> +	   hv_dev_is_fc(device))) {
>  		vstor_packet->vm_srb.scsi_status = 0;
>  		vstor_packet->vm_srb.srb_status = SRB_STATUS_SUCCESS;
>  	}
> --
> 2.42.0

Reviewed-by: Michael Kelley <mhklinux@...look.com>