[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNAREx+QUT3BA5disV6kkq9uX1i8nZS_nRJwJZHHdGKCXHw@mail.gmail.com>
Date: Thu, 28 Nov 2024 07:50:05 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: David Hunter <david.hunter.linux@...il.com>
Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
shuah@...nel.org, javier.carrasco.cruz@...il.com,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 7/7] streamline_config.pl: check prompt for bool options
On Wed, Nov 27, 2024 at 10:27 PM David Hunter
<david.hunter.linux@...il.com> wrote:
>
>
> > As I reviewed in v1, this patch depends on 6/7.
>
> Hello,
>
> I am a little confused by this part. I originally understood this to say
> that I should put it after the 6/7 patch because it depends on it.
> Should I have combined the two patches into one?
>
> Sorry for not understanding.
No. What I understood from Steven's feedback is,
6/7 is skeptical.
6/7 enables many unnecessary modules because of them depending on 'y',
but most of the cases, the 'y' value is module-internal switch.
While 6/7 may save some false-negatives,
it introduces many false-positives.
So, I do not know whether it should get in or not.
If we do not apply 6/7, there is not reason to apply 7/7 either.
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists