linux-kernel - Re: [PATCH] x86/aesni: fix uninit value for skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241127235518.GA870796@google.com>
Date: Wed, 27 Nov 2024 23:55:18 +0000
From: Eric Biggers <ebiggers@...nel.org>
To: Ragavendra <ragavendra.bn@...il.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, tglx@...utronix.de,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
	hpa@...or.com, x86@...nel.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/aesni: fix uninit value for skcipher_walk

On Wed, Nov 27, 2024 at 03:43:47PM -0800, Ragavendra wrote:
> In crypto/aesni-intel_glue.c most declarations of struct
> skcipher_walk are unitialized. This causes one of the values
> in the struct to be left uninitialized in the later usages.
> 
> This patch fixes it by adding initializations to the struct
> skcipher_walk walk variable.
> 
> Fixes bugs reported in the Coverity scan with CID 139545,
> 1518179, 1585019 and 1598915.
> 
> Signed-off-by: Ragavendra Nagraj <ragavendra.bn@...il.com>

This should be fixed in skcipher_walk_virt(), not in every caller.

- Eric