linux-kernel - Re: [GIT PULL] Rust for 6.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nqyFHkQFRLoXSA5BEvgNz_8iOCK+A1gU+2ubnJRd-OwA@mail.gmail.com>
Date: Wed, 27 Nov 2024 01:19:32 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] Rust for 6.13

On Tue, Nov 26, 2024 at 11:08 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Well, please humor me. My conflict resolution isn't identical to
> linux-next, and my rust is still very much "monkey see, monkey do", so
> you should most definitely check it out.

It builds fine -- both after the vfs pid_namespace and after the rust one.

...except rustfmt wants to move the `use` imports a bit in
rust/kernel/task.rs. Do you prefer a quick patch, or do you want to
run `make rustfmt` on your end?

Doing the latter would leave you with what linux-next has for those
`use`s. You can also move the `ffi::...` one inside the `crate::...`
import and run `rustfmt` which makes it look a bit more consistent:

    use crate::{
        bindings,
        ffi::{c_int, c_long, c_uint},
        pid_namespace::PidNamespace,
        types::{ARef, NotThreadSafe, Opaque},
    };
    use core::{
        cmp::{Eq, PartialEq},
        ops::Deref,
        ptr,
    };

Thanks!

Cheers,
Miguel