linux-kernel - Re: [PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3df3d649-b921-49db-a050-ef935b7e9748@ti.com>
Date: Wed, 27 Nov 2024 10:32:30 +0530
From: Vaishnav Achath <vaishnav.a@...com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <peter.ujfalusi@...il.com>,
        <vkoul@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <dmaengine@...r.kernel.org>,
        <devicetree@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, <u-kumar1@...com>, <j-choudhary@...com>,
        <vigneshr@...com>
Subject: Re: [PATCH v2 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI
 BCDMA

Hi Krzysztof,

On 26/11/24 19:49, Krzysztof Kozlowski wrote:
> On 26/11/2024 13:51, Vaishnav Achath wrote:
>> J722S CSI BCDMA is similar to J721S2 CSI BCDMA and
>> supports both RX and TX channels. Add an entry for
>> J722S CSIRX BCDMA.
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 

I will fix this in next revision.

>>
>> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
>> ---
>>
>> V1->V2:
>>    * Address review from Conor to add new J722S compatible
>>    * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
>>    add an entry alongside J721S2 instead of modifying AM62A.
>>
>> V1: https://lore.kernel.org/all/20241125083914.2934815-1-vaishnav.a@ti.com/
>>
>>   Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> index 27b8e1636560..37832c71bd8e 100644
>> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
>> @@ -196,7 +196,9 @@ allOf:
>>         properties:
>>           compatible:
>>             contains:
>> -            const: ti,j721s2-dmss-bcdma-csi
>> +            enum:
>> +              - ti,j721s2-dmss-bcdma-csi
>> +              - ti,j722s-dmss-bcdma-csi
> 
> This compatible was never documented. There is no dependency here, no
> cover letter explaining where is this compatible introduced.
> 
> 

This was a mistake from my end, sorry about that, it was supposed to be 
introduced in this patch itself, will fix it in the next revision. Thank 
you for the review.

Thanks and Regards,
Vaishnav

> 
> 
> Best regards,
> Krzysztof