linux-kernel - Re: [PATCH v6 3/5] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60f52d54-da36-4223-9063-b833451781ea@prolan.hu>
Date: Wed, 27 Nov 2024 08:12:11 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: Mark Brown <broonie@...nel.org>
CC: <linux-sound@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-sunxi@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, Mesih Kilinc
	<mesihkilinc@...il.com>, Liam Girdwood <lgirdwood@...il.com>, Jaroslav Kysela
	<perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Chen-Yu Tsai
	<wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland
	<samuel@...lland.org>
Subject: Re: [PATCH v6 3/5] ASoC: sun4i-codec: Add support for Allwinner suniv
 F1C100s

Hi,

On 2024. 11. 26. 13:18, Mark Brown wrote:
> On Sat, Nov 23, 2024 at 01:39:02PM +0100, Csókás, Bence wrote:
> 
>> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>
> 
> When you write your signoffs like this with the , but no "" (like in
> your From:) it confuses software and causes everything after the , to
> get deleted.  Probably just including the quotes is the best option to
> match the email header.

Git handles it fine since 2.46, before that there was some weirdness in 
send-email not adding it to the Cc: correctly, but git am & co. worked 
fine. b4 still has issues with it unfortunately.
Link: https://github.com/mricon/b4/issues/50

However, the real problem I think is that git format-patch doesn't add 
the quotes. What's worse, you'll have a real hard time trying to git 
config --global user.name "a quoted string". Git tries *really* hard to 
remove surrounding quotation (and is further aided by the shell). I'll 
see what I can do.

Bence