linux-kernel - Re: RE: [EXT] Re: [PATCH v3] i2c: imx: support DMA defer probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241127-analytic-azure-hamster-727fd8-mkl@pengutronix.de>
Date: Wed, 27 Nov 2024 08:58:49 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Carlos Song <carlos.song@....com>
Cc: Frank Li <frank.li@....com>, 
	"o.rempel@...gutronix.de" <o.rempel@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, 
	"andi.shyti@...nel.org" <andi.shyti@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, 
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, 
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: RE: [EXT] Re: [PATCH v3] i2c: imx: support DMA defer probing

On 27.11.2024 07:48:13, Carlos Song wrote:
> > >  static void i2c_imx_dma_callback(void *arg) @@ -1803,6 +1804,23 @@
> > > static int i2c_imx_probe(struct platform_device *pdev)
> > >  	if (ret == -EPROBE_DEFER)
> > >  		goto clk_notifier_unregister;
> > >
> > > +	/*
> > > +	 * Init DMA config if supported, -ENODEV means DMA not enabled at
> > > +	 * this platform, that is not a real error, so just remind "only
> > > +	 * PIO mode is used". If DMA is enabled, but meet error when request
> > > +	 * DMA channel, error should be showed in probe error log. PIO mode
> > > +	 * should be available regardless of DMA.
> > > +	 */
> > > +	ret = i2c_imx_dma_request(i2c_imx, phy_addr);
> > > +	if (ret) {
> > > +		if (ret == -EPROBE_DEFER)
> > > +			goto clk_notifier_unregister;
> > > +		else if (ret == -ENODEV)
> > > +			dev_info(&pdev->dev, "Only use PIO mode\n");
> > 
> > On a system without DMA configured, with this patch we now get this info
> > message that wasn't there before. I think this might annoy some people, so you
> > should remove it.
> > 
> 
> :-) hhh, get it.

Some things look reasonable when discussing the patch, but when you
see the new, cleaned-up version, you immediately realize that this is
going to annoy people :)

> How about change to dev_dbg?

Good idea.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)