linux-kernel - Re: [PATCH v3 3/5] ASoC: codecs: wcd937x: Add static channel mapping support in wcd937x-sdw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <y2dllg7ie475xvowbqtmh7rgdmcyqr6tinik2o66rru3ccuvqv@7d6v7l64lnh7>
Date: Wed, 27 Nov 2024 09:09:40 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Vinod Koul <vkoul@...nel.org>, Bard Liao <yung-chuan.liao@...ux.intel.com>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>, Sanyog Kale <sanyog.r.kale@...el.com>, 
	linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, quic_rohkumar@...cinc.com, kernel@...cinc.com
Subject: Re: [PATCH v3 3/5] ASoC: codecs: wcd937x: Add static channel mapping
 support in wcd937x-sdw

On Tue, Nov 26, 2024 at 10:12:58PM +0530, Mohammad Rafi Shaik wrote:
> Add static channel mapping between master and slave ports in
> wcd937x-sdw driver.
> 
> Currently, the channel mask for each soundwire port is hardcoded in the
> wcd937x-sdw driver, and the same channel mask value is configured in the
> soundwire master.
> 
> The Qualcomm boards like the QCM6490-IDP require different channel mask
> settings for the soundwire master and slave ports.
> 
> Implemented logic to read TX/RX channel mappings from device tree
> properties (qcom,tx-channel-mapping and qcom,rx-channel-mapping).
> 
> Modified the wcd937x_connect_port to handle master channel masks during
> port enable/disable operations.
> 
> Added wcd937x_get_channel_map api to retrieve the current master
> channel map for TX and RX paths.
> 
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@...cinc.com>
> ---
>  sound/soc/codecs/wcd937x-sdw.c | 38 +++++++++++++++++++++---
>  sound/soc/codecs/wcd937x.c     | 53 ++++++++++++++++++++++++++++++++--
>  sound/soc/codecs/wcd937x.h     |  6 +++-
>  3 files changed, 90 insertions(+), 7 deletions(-)
> 
> diff --git a/sound/soc/codecs/wcd937x-sdw.c b/sound/soc/codecs/wcd937x-sdw.c
> index 0c33f7f3dc25..3263bdf25d86 100644
> --- a/sound/soc/codecs/wcd937x-sdw.c
> +++ b/sound/soc/codecs/wcd937x-sdw.c
> @@ -19,7 +19,7 @@
>  #include <sound/soc.h>
>  #include "wcd937x.h"
>  

I don't see the bindings header being used here, so this is a proof for
you that these are not bindings constants.

Best regards,
Krzysztof