linux-kernel - Re: [PATCH v2 1/3] ARM: imx: Allow user to disable pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttbthwdu.fsf@prevas.dk>
Date: Wed, 27 Nov 2024 10:13:49 +0100
From: Rasmus Villemoes <ravi@...vas.dk>
To: Fabio Estevam <festevam@...il.com>
Cc: Guenter Roeck <linux@...ck-us.net>,  Linus Walleij
 <linus.walleij@...aro.org>,  Esben Haabendal <esben@...nix.com>,  Russell
 King <linux@...linux.org.uk>,  Shawn Guo <shawnguo@...nel.org>,  Sascha
 Hauer <s.hauer@...gutronix.de>,  Pengutronix Kernel Team
 <kernel@...gutronix.de>,  Dong Aisheng <aisheng.dong@....com>,  Jacky Bai
 <ping.bai@....com>,  Arnd Bergmann <arnd@...db.de>,
  linux-arm-kernel@...ts.infradead.org,  imx@...ts.linux.dev,
  linux-kernel@...r.kernel.org,  linux-gpio@...r.kernel.org,  Fabio Estevam
 <festevam@...x.de>
Subject: Re: [PATCH v2 1/3] ARM: imx: Allow user to disable pinctrl

On Tue, Nov 26 2024, Fabio Estevam <festevam@...il.com> wrote:

> On Tue, Nov 26, 2024 at 8:53 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
>> My understanding (which may be wrong) is that being able to disable
>> PINCTRL was the whole point of the patch.
>
> Exactly.
>
> Adding back the "select PINCTRL" line defeats the purpose of the patch
> in Subject.
>

Yup.

>> Fabio submitted a patch enabling PINCTRL for imx_v4_v5_defconfig and
>> imx_v6_v7_defconfig explicitly [1]. I don't know if that fixes the
>> problem for good - I see CONFIG_ARCH_MXC in other configurations as
>> well.
>
> Good point. I can send a v2 adding CONFIG_PINCTRL=y to the other defconfigs.
>

Instead of doing that, isn't this exactly what the 'imply' keyword is
for?

- weak reverse dependencies: "imply" <symbol> ["if" <expr>]

  This is similar to "select" as it enforces a lower limit on another
  symbol except that the "implied" symbol's value may still be set to n
  from a direct dependency or with a visible prompt.


So how about adding 'imply PINCTRL' in lieu of the previous 'select
PINCTRL'? And that would also better match the intention of the patch in
question (namely that the user needs to take explicit action to disable
PINCTRL).

Rasmus