linux-kernel - Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30b208e0-55a2-400f-9638-1765e7ed3bfa@web.de>
Date: Wed, 27 Nov 2024 13:40:09 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Baichuan Qi <zghbqbc@...il.com>, ath11k@...ts.infradead.org,
 linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Jeff Johnson <jjohnson@...nel.org>
Subject: Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe()

>> Is there a need to reconsider also such a return value?
>
> According to the current code (commit d5c65159f289) of
> this function, this function should be terminated directly
> after checking the null pointer, the return value may be
> meaningless.
The return value is checked at two source code places at least.

* ath11k_ce_recv_process_cb():
  https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L450

* ath11k_ce_rx_post_buf():
  https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L893


May the detection of a null pointer for the data structure members
“dest_ring” or “status_ring” really be interpreted as a successful execution
of the function “ath11k_ce_rx_post_pipe”?

Regards,
Markus