linux-kernel - Re: [PATCH v2] clk: renesas: cpg-mssr: fix 'soc' node handling in cpg_mssr_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV+bvYQoOLxZ_eVRN2F604k1saJs5vbCLug0BmhVnKx3A@mail.gmail.com>
Date: Wed, 27 Nov 2024 14:01:12 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, linux-renesas-soc@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] clk: renesas: cpg-mssr: fix 'soc' node handling in cpg_mssr_reserved_init()

On Thu, Oct 31, 2024 at 1:43 PM Javier Carrasco
<javier.carrasco.cruz@...il.com> wrote:
> A device_node reference obtained via of_find_node_by_path() requires
> explicit calls to of_node_put() after it is no longer required to avoid
> leaking the resource.
>
> Instead of adding the missing calls to of_node_put() in all execution
> paths, use the cleanup attribute for 'soc' by means of the __free()
> macro, which automatically calls of_node_put() when the variable goes
> out of scope.
>
> Fixes: 6aa175476490 ("clk: renesas: cpg-mssr: Ignore all clocks assigned to non-Linux system")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
> Changes in v2:
> - Squash patches for mainline solution without intermediate steps.
> - Link to v1: https://lore.kernel.org/r/20241031-clk-renesas-cpg-mssr-cleanup-v1-0-628274ecbfcb@gmail.com

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-clk for v6.14.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds