linux-kernel - Re: [PATCH v2] rtla/timerlat: Fix histogram ALL for zero samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvS0RuUH+RLWHBEQuFh=2-s43vxUw632-i_Lxd6h4+Gd7Q@mail.gmail.com>
Date: Wed, 27 Nov 2024 14:50:33 +0100
From: Tomas Glozar <tglozar@...hat.com>
To: rostedt@...dmis.org
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	jkacur@...hat.com
Subject: Re: [PATCH v2] rtla/timerlat: Fix histogram ALL for zero samples

st 27. 11. 2024 v 14:42 odesílatel <tglozar@...hat.com> napsal:
>
> Fix the bug by omitting max/min/avg when sample count is zero,
> displaying a dash instead, just like we already do for the individual
> CPUs. The logic is moved into a new function called
> format_summary_value, which is used for both the individual CPUs
> and for the overall summary.
>

Note that the code is still repeated 18 times = 3 latencies (user,
thread, irq) times 3 summaries (max, min, avg) * 2 kinds (per-cpu,
overall). Due to the way the storing of the values and the printing is
implemented, it is not straightforward to reduce this code duplicity.
There are 9 different fields: (max, min, avg) * (user, thread, irq) -
of timerlat_hist_cpu, and min/max/avg are grouped together per-CPU.

I will send another patch to remove the duplicity if I get an idea how
to deal with it. The duplicity was there also before and is thus not
in the scope of this fix.

Tomas