linux-kernel - Re: [PATCH can-next] dt-bindings: can: tcan4x5x: add missing required clock-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241127-myth-lily-122b9839cc0b@spud>
Date: Wed, 27 Nov 2024 16:18:59 +0000
From: Conor Dooley <conor@...nel.org>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next] dt-bindings: can: tcan4x5x: add missing
 required clock-names

On Wed, Nov 27, 2024 at 05:10:31PM +0100, Sean Nyekjaer wrote:
> On Wed, Nov 27, 2024 at 04:56:13PM +0100, Sean Nyekjaer wrote:
> > Hi Conor,
> > 
> > On Wed, Nov 27, 2024 at 03:50:30PM +0100, Conor Dooley wrote:
> > > On Wed, Nov 27, 2024 at 02:40:47PM +0100, Sean Nyekjaer wrote:
> > > > tcan4x5x requires an external clock called cclk, add it here.
> > > 
> > > That's not what this patch is doing, the clock input is already there,
> > > so I don't know what this patch actually accomplishes? clock-names isn't
> > > a required property, so you can't even use it in a driver.
> > > 
> > 
> > Thanks for asking the right questions :)
> > 
> > I know the clock input is there, but it looks (to me) like the driver looks for the
> > specific clock called cclk:
> > https://elixir.bootlin.com/linux/v6.12/source/drivers/net/can/m_can/m_can.c#L2299
> > https://elixir.bootlin.com/linux/v6.12/source/drivers/net/can/m_can/tcan4x5x-core.c#L396
> 
> Oh I really need to get my head around the dt jargon :)
> Yes I'll add the clock-names to the required list for v2!

btw, where even is ti,tcan4x5x.yaml? I was gonna paste the fixes tag you
should be using but I couldn't find the file in linux-next.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)