linux-kernel - Re: [PATCH 2/9] dt-bindings: phy: samsung,usb3-drd-phy: add optional orientation-switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fba9c9df33dc2e060238a9bb3466a2fea020efde.camel@linaro.org>
Date: Wed, 27 Nov 2024 16:27:09 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Conor Dooley <conor@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>,  Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,  Marek Szyprowski
 <m.szyprowski@...sung.com>, Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, Peter Griffin
 <peter.griffin@...aro.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, Sam
 Protsenko <semen.protsenko@...aro.org>, Will McVicker
 <willmcvicker@...gle.com>, Roy Luo <royluo@...gle.com>,
 kernel-team@...roid.com,  linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,  linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: phy: samsung,usb3-drd-phy: add
 optional orientation-switch

Hi Conor,

Thanks for your review.

On Wed, 2024-11-27 at 16:02 +0000, Conor Dooley wrote:
> On Wed, Nov 27, 2024 at 04:00:59PM +0000, Conor Dooley wrote:
> > On Wed, Nov 27, 2024 at 10:58:12AM +0000, André Draszik wrote:
> > > orientation-switch is the standard declaration to inform the Type-C
> > > mux
> > > layer that a remote-endpoint is capable of processing orientation
> > > change messages.
> > > 
> > > Add as an optional since not all versions of this phy currently
> > > support
> > > or even need the orientation-switch.
> > > 
> > > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > 
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Actually, this patch unconditionally adds the property to the binding.
> Is it valid for !gs101?

Good point. I've only made it required for gs101 in the next patch, but as-
is, somebody could still add it (in error) in !gs101 cases.

I guess it's best to squash patches 3 and 4 in that case, and update it to
disallow for !gs101.

Thanks,
Andre'