linux-kernel - Re: [PATCH] sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd2T0-k-RuVK37zmEzWPAnWAhpRN2cBANvg=ENT0_oGFg@mail.gmail.com>
Date: Wed, 27 Nov 2024 19:45:13 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Valentin Schneider <vschneid@...hat.com>
Cc: linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, 
	Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, 
	Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, 
	Dietmar Eggemann <dietmar.eggemann@....com>, Steven Rostedt <rostedt@...dmis.org>, 
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH] sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used()

On Wed, Nov 27, 2024 at 6:55 PM Valentin Schneider <vschneid@...hat.com> wrote:
>
> Andy reported that clang gets upset with CONFIG_CFS_BANDWIDTH=n:
>
>   kernel/sched/fair.c:6580:20: error: unused function 'cfs_bandwidth_used' [-Werror,-Wunused-function]
>    6580 | static inline bool cfs_bandwidth_used(void)
>         |                    ^~~~~~~~~~~~~~~~~~
>
> Indeed, cfs_bandwidth_used() is only used within functions defined under
> CONFIG_CFS_BANDWIDTH=y. Remove its CONFIG_CFS_BANDWIDTH=n declaration &
> definition.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Thank you for fixing this issue!

-- 
With Best Regards,
Andy Shevchenko