linux-kernel - [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com>
Date: Wed, 27 Nov 2024 18:07:25 +0000
From: Karan Sanghavi <karansanghvi98@...il.com>
To: Hugh Dickins <hughd@...gle.com>, 
 Andrew Morton <akpm@...ux-foundation.org>, 
 Gabriel Krisman Bertazi <gabriel@...sman.be>, 
 André Almeida <andrealmeid@...lia.com>, 
 Christian Brauner <brauner@...nel.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
 Shuah Khan <skhan@...uxfoundation.org>, 
 Karan Sanghavi <karansanghvi98@...il.com>
Subject: [PATCH v2] mm: shmem: Fix variable type to int to evaluate
 negative conditions

Use signed data type for version handling
in shmem_parse_opt_casefold()

Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
Reviewed-by: André Almeida <andrealmeid@...lia.com>
Reviewed-by: Gabriel Krisman Bertazi <gabriel@...sman.be>
Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
---
Coverity Message:
CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned 
value is never true. version < 0U

Coverity Link:
https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569
---
Changes in v2:
- Updated the log summary.
- Link to v1: https://lore.kernel.org/r/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com
---
 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index 7987deb2be9b..17a1d4fa8870 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter *
 				    bool latest_version)
 {
 	struct shmem_options *ctx = fc->fs_private;
-	unsigned int version = UTF8_LATEST;
+	int version = UTF8_LATEST;
 	struct unicode_map *encoding;
 	char *version_str = param->string + 5;
 

---
base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2
change-id: 20241111-unsignedcompare1601569-05b5932145ef

Best regards,
-- 
Karan Sanghavi <karansanghvi98@...il.com>