linux-kernel - Re: [PATCH v4 3/6] cxl/events: Update General Media Event Record to CXL spec rev 3.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241127133407.7bc1376a@gandalf.local.home>
Date: Wed, 27 Nov 2024 13:34:07 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Shiju Jose <shiju.jose@...wei.com>
Cc: "dave.jiang@...el.com" <dave.jiang@...el.com>,
 "dan.j.williams@...el.com" <dan.j.williams@...el.com>, Jonathan Cameron
 <jonathan.cameron@...wei.com>, "alison.schofield@...el.com"
 <alison.schofield@...el.com>, "nifan.cxl@...il.com" <nifan.cxl@...il.com>,
 "vishal.l.verma@...el.com" <vishal.l.verma@...el.com>,
 "ira.weiny@...el.com" <ira.weiny@...el.com>, "dave@...olabs.net"
 <dave@...olabs.net>, "linux-cxl@...r.kernel.org"
 <linux-cxl@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Linuxarm <linuxarm@...wei.com>, tanxiaofei
 <tanxiaofei@...wei.com>, "Zengtao (B)" <prime.zeng@...ilicon.com>
Subject: Re: [PATCH v4 3/6] cxl/events: Update General Media Event Record to
 CXL spec rev 3.1

On Wed, 27 Nov 2024 18:20:26 +0000
Shiju Jose <shiju.jose@...wei.com> wrote:

> I tested removing hdr_uuid and region_uuid from the rasdaemon test setup
> as you suggested. As a result, libtraceevent parses correctly, as you mentioned.
> 
> However, I encounter  similar parsing error ("FAILED TO PARSE") when I add two additional
> decoded strings (%s) to the TP_printk, replacing (%u). Please see the attached format file,
> "format_cxl_general_media_v3.1_basic", for your reference.

Are you sure. I don't see anything wrong with that one. Which version of
libtraceevent do you have?

> 
> I've also attached another format file, "format_cxl_general_media_v3.1_full",
> which contains the complete TP_printk() intended.

This one has some complex arguments and also uses the '&' address of an
argument.

>  
> Can you please help or else can you share how to debug these errors in the
> libtraceevent setup?

Basically, I use the attached program (that just links to libtraceevent).

Note, I need to delete the first line of your files, which has the "cat"
command. But you can run this on the file itself:

  ./tep_load_event /sys/kernel/tracing/events/cxl/cxl_general_media/format

But you may need to be root to do that. If root just copies that file, you
can then run it as non-root.

 # cp /sys/kernel/tracing/events/cxl/cxl_general_media/format /tmp
 $ ./tep_load_event /tmp/format

I run it under gdb and see where it fails. But it should let you know if it
will pass or not. I put a breakpoint on tep_warning and when it gets hit, I
examine what it did up to that point.

-- Steve


View attachment "tep_load_event.c" of type "text/x-c++src" (1628 bytes)