linux-kernel - Re: [RFC PATCH 1/3] module: Split module_enable_rodata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0drL3oXxkRWiNTs@bombadil.infradead.org>
Date: Wed, 27 Nov 2024 10:55:43 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Petr Pavlu <petr.pavlu@...e.com>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Daniel Gomez <da.gomez@...sung.com>, Kees Cook <kees@...nel.org>,
	linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC PATCH 1/3] module: Split module_enable_rodata_ro()

On Wed, Nov 27, 2024 at 02:37:40PM +0100, Christophe Leroy wrote:
> 
> 
> Le 26/11/2024 à 20:58, Luis Chamberlain a écrit :
> > On Sat, Nov 09, 2024 at 11:35:35AM +0100, Christophe Leroy wrote:
> > > module_enable_rodata_ro() is called twice, once before module init
> > > to set rodata sections readonly and once after module init to set
> > > rodata_after_init section readonly.
> > > 
> > > The second time, only the rodata_after_init section needs to be
> > > set to read-only, no need to re-apply it to already set rodata.
> > > 
> > > Split module_enable_rodata_ro() in two.
> > > 
> > > Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > 
> > Didn't see a respin so this will have to be a post v6.13-rc1 fix.
> 
> Indeed I was waiting for v6.13-rc1 before sending the non RFC rebased
> version, but I can send it now if you prefer.
> 
> I expect it to spend a few days in linux-next before being applied to
> mainline.

No rush on my end, let's wait as you noted until v6.13-rc1 is out.

  Luis