linux-kernel - 回覆: [PATCH net-next v3 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SEYPR06MB51343FAEFF3B4F6B3A9DD0959D282@SEYPR06MB5134.apcprd06.prod.outlook.com>
Date: Wed, 27 Nov 2024 03:48:02 +0000
From: Jacky Chou <jacky_chou@...eedtech.com>
To: Philipp Zabel <p.zabel@...gutronix.de>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "ratbert@...aday-tech.com"
	<ratbert@...aday-tech.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject:
 回覆: [PATCH net-next v3 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs

Hi Philipp,

Thank you for your reply.

> > +	priv->rst = devm_reset_control_get_optional_exclusive(priv->dev, NULL);
> > +	if (IS_ERR(priv->rst))
> > +		goto err_register_netdev;
> > +	if (!priv->rst)
> > +		dev_info(&pdev->dev, "no reset control found\n");
> 
> Am I understanding correctly that the aspeed-g4 to g6 platforms don't have the
> reset? If so, this message is unnecessary noise on those platforms.

Agree. There is no reset property for aspeed-g4 to g6 platforms.
Indeed, even if the reset does not exist, there is no need to display the message.
I will remove the message in next version.

Thanks,
Jacky