linux-kernel - Re: [PATCH] mm/zswap: add LRU_STOP to comment about dropping the lru lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abedc173-0760-41fd-a73d-e84dccfc3209@linux.dev>
Date: Thu, 28 Nov 2024 10:32:09 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Alice Ryhl <aliceryhl@...gle.com>, Johannes Weiner <hannes@...xchg.org>,
 Yosry Ahmed <yosryahmed@...gle.com>, Nhat Pham <nphamcs@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/zswap: add LRU_STOP to comment about dropping the lru
 lock

On 2024/11/27 21:53, Alice Ryhl wrote:
> This function has been able to return LRU_STOP since commit b49547ade38a
> ("mm/zswap: stop lru list shrinking when encounter warm region"). To
> reduce confusion, update the comment to also list LRU_STOP as an option.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

Reviewed-by: Chengming Zhou <chengming.zhou@...ux.dev>

Thanks!

> ---
>   mm/zswap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index f6316b66fb23..9718c33f8192 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1156,7 +1156,7 @@ static enum lru_status shrink_memcg_cb(struct list_head *item, struct list_lru_o
>   
>   	/*
>   	 * It's safe to drop the lock here because we return either
> -	 * LRU_REMOVED_RETRY or LRU_RETRY.
> +	 * LRU_REMOVED_RETRY, LRU_RETRY or LRU_STOP.
>   	 */
>   	spin_unlock(&l->lock);
>   
> 
> ---
> base-commit: aaf20f870da056752f6386693cc0d8e25421ef35
> change-id: 20241127-lru-stop-comment-09dab2427b6e
> 
> Best regards,